Fixed some minor spelling errors #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handrews
reviewed
Dec 17, 2018
jsonschema-core.xml
Outdated
| @@ -1930,7 +1930,7 @@ | |||
| its elements is valid against the given schema. This keyword | |||
| does not produce annotation results. | |||
| <cref> | |||
| Should it produce a set of the indices for which the | |||
There was a problem hiding this comment.
Both spellings are correct, and a search of RFCs on ietf.org shows that both are roughly equally popular. I would prefer to stick with indices as that's what we've always used in this project and changing it means we will almost certainly end up inconsistent.
There was a problem hiding this comment.
Ooops sorry, I'm so used to use "indexes" that I didn't confirm that "indices" was actually correct.
|
BTW, I opened this PR just to help you catch some minor spelling errors before final draft, please feel free to correct that in any PR and squash the changes there. |
awwright
approved these changes
Dec 18, 2018
dlax
approved these changes
Dec 18, 2018
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.